4.13/master stabilisation PR by yadvr · Pull Request #3547 · apache/cloudstack

yadvr · 2019-08-08T06:41:23Z

Smoketests fixes. Refer health check PR #3517

Known/Failing tests:

Test	Result	Time (s)	Test File
test_reboot_router	Error	349.14	test_network.py
test_08_start_router	Error	71.81	test_routers.py
test_09_reboot_router	Error	0.12	test_routers.py
test_02_list_snapshots_with_removed_data_store	Error	1.18	test_snapshots.py
test_01_volume_usage	Error	9.42	test_usage.py

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2019-08-09T10:59:44Z

@blueorangutan package

blueorangutan · 2019-08-09T11:00:27Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-08-09T11:21:05Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-238

yadvr · 2019-08-09T11:47:50Z

@blueorangutan test

blueorangutan · 2019-08-09T11:48:27Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-08-09T21:22:08Z

Trillian test result (tid-296)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32562 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3547-t296-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2019-08-10T04:13:12Z

Trillian test result (tid-298)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33359 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3547-t298-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 73 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_reboot_router	`Error`	273.73	test_network.py
test_08_start_router	`Error`	51.08	test_routers.py
test_09_reboot_router	`Error`	1.10	test_routers.py
test_02_list_snapshots_with_removed_data_store	`Error`	1.13	test_snapshots.py
test_01_volume_usage	`Error`	8.32	test_usage.py

yadvr · 2019-08-10T15:50:02Z

@blueorangutan package

blueorangutan · 2019-08-10T15:50:33Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-08-10T16:11:48Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-244

yadvr · 2019-08-10T18:01:05Z

@blueorangutan test centos7 xenserver-71

blueorangutan · 2019-08-10T18:01:32Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

blueorangutan · 2019-08-11T16:33:12Z

Trillian test result (tid-301)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35354 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3547-t301-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_list_snapshots	`Error`	0.03	test_list_ids_parameter.py
test_01_scale_vm	`Failure`	30.67	test_scale_vm.py

blueorangutan · 2019-08-11T17:47:47Z

Trillian test result (tid-302)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32932 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3547-t302-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 73 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_reboot_router	`Error`	306.36	test_network.py
test_08_start_router	`Error`	58.25	test_routers.py
test_09_reboot_router	`Error`	1.09	test_routers.py
test_02_list_snapshots_with_removed_data_store	`Error`	1.14	test_snapshots.py
test_01_volume_usage	`Error`	8.31	test_usage.py

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

…ipts Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2019-08-12T10:50:01Z

@blueorangutan package

blueorangutan · 2019-08-12T10:50:40Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-08-12T11:11:33Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-245

yadvr · 2019-08-12T11:27:03Z

@blueorangutan test centos7 xenserver-71

blueorangutan · 2019-08-12T11:27:41Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

yadvr · 2019-08-12T11:28:02Z

@blueorangutan test

blueorangutan · 2019-08-12T11:28:40Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-08-12T21:40:45Z

Trillian test result (tid-304)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35374 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3547-t304-vmware-65u2.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2019-08-12T23:03:27Z

Trillian test result (tid-306)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39964 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3547-t306-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2019-08-12T23:46:57Z

Trillian test result (tid-307)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34334 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3547-t307-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Failure`	24.56	test_scale_vm.py

anuragaw

LGTM overall but an optional minor suggestion within.

anuragaw · 2019-08-13T06:11:07Z

                    oldNicIdString, oldNetworkOfferingId, null, 0L, VirtualMachine.class.getName(), vmInstance.getUuid(), vmInstance.isDisplay());

-            if (vmInstance.getState() != State.Stopped) {
+            if (vmInstance.getState() == State.Running) {


Log warning perhaps if this method is called when not in running state?

I think the case should trigger only when user vm is in running state

shwstppr

LGTM based on test results, changes!

borisstoyanov

LGTM, I think scale VM xen failure is due to a license limitation

systemvm: add enable statement

99d19db

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added this to the 4.13.0.0 milestone Aug 8, 2019

yadvr added the Severity:BLOCKER label Aug 9, 2019

yadvr added 2 commits August 9, 2019 15:50

defensive fixes

05900ab

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

fix another potential NPE

4184e05

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

apache deleted a comment from blueorangutan Aug 10, 2019

yadvr added 4 commits August 12, 2019 14:08

fix npe

f2f1ce3

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

fix another npe

06a1821

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

npe fix improvement

0fac5be

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

fix valueerror issue when 0bytes sized config are processed by VR scr…

1e56b95

…ipts Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr requested review from PaulAngus, andrijapanicsb and borisstoyanov August 12, 2019 10:52

anuragaw approved these changes Aug 13, 2019

View reviewed changes

shwstppr approved these changes Aug 13, 2019

View reviewed changes

borisstoyanov approved these changes Aug 13, 2019

View reviewed changes

yadvr changed the title ~~[WIP] 4.13/master stabilisation PR~~ 4.13/master stabilisation PR Aug 13, 2019

yadvr merged commit b576972 into apache:master Aug 13, 2019

yadvr mentioned this pull request Aug 13, 2019

4.13.0.0/master: health checks smoketests #3517

Closed

yadvr mentioned this pull request Sep 10, 2019

Ensure VM deletion when default nic is removed does not cause stale entries in DB and router #3592

Closed

Conversation

yadvr commented Aug 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Uh oh!

yadvr commented Aug 9, 2019

Uh oh!

blueorangutan commented Aug 9, 2019

Uh oh!

blueorangutan commented Aug 9, 2019

Uh oh!

yadvr commented Aug 9, 2019

Uh oh!

blueorangutan commented Aug 9, 2019

Uh oh!

blueorangutan commented Aug 9, 2019

Uh oh!

blueorangutan commented Aug 10, 2019

Uh oh!

yadvr commented Aug 10, 2019

Uh oh!

blueorangutan commented Aug 10, 2019

Uh oh!

blueorangutan commented Aug 10, 2019

Uh oh!

yadvr commented Aug 10, 2019

Uh oh!

blueorangutan commented Aug 10, 2019

Uh oh!

blueorangutan commented Aug 11, 2019

Uh oh!

blueorangutan commented Aug 11, 2019

Uh oh!

yadvr commented Aug 12, 2019

Uh oh!

blueorangutan commented Aug 12, 2019

Uh oh!

blueorangutan commented Aug 12, 2019

Uh oh!

yadvr commented Aug 12, 2019

Uh oh!

blueorangutan commented Aug 12, 2019

Uh oh!

yadvr commented Aug 12, 2019

Uh oh!

blueorangutan commented Aug 12, 2019

Uh oh!

blueorangutan commented Aug 12, 2019

Uh oh!

blueorangutan commented Aug 12, 2019

Uh oh!

blueorangutan commented Aug 12, 2019

Uh oh!

anuragaw left a comment

Choose a reason for hiding this comment

Uh oh!

anuragaw Aug 13, 2019

Choose a reason for hiding this comment

Uh oh!

yadvr Aug 13, 2019

Choose a reason for hiding this comment

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yadvr commented Aug 8, 2019 •

edited

Loading